mirror of
https://github.com/prompt-security/clawsec.git
synced 2026-06-13 05:28:02 +03:00
c9a66d5c99
* refactor: extract shared test harness module from 9 test files Extract duplicated test utilities into a reusable test_harness.mjs module to eliminate ~200-250 lines of boilerplate code across test files. Changes: - Create skills/clawsec-suite/test/lib/test_harness.mjs with: - Test reporting: pass(), fail(), report(), exitWithResults() - Crypto utilities: generateEd25519KeyPair(), signPayload() - Temp directory: createTempDir() with cleanup - Environment helpers: withEnv() for isolated env vars - Test runner factory: createTestRunner() for isolated counters - Refactor 9 test files to use shared harness: - feed_verification.test.mjs - guarded_install.test.mjs - skill_catalog_discovery.test.mjs - advisory_suppression.test.mjs - advisory_application_scope.test.mjs - path_resolution.test.mjs - fuzz_properties.test.mjs - suppression_config.test.mjs - render_report_suppression.test.mjs Benefits: - Single source of truth for test utilities - Consistent test reporting across all files - Easier to add new test files - Reduced maintenance burden Verification: - All 80 tests pass (15+8+3+15+4+6+1+17+11) - Zero ESLint warnings - No behavior changes - only code deduplication - Cross-skill module sharing works (openclaw-audit-watchdog → clawsec-suite) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: update minimatch override to 10.2.4 to resolve ReDoS vulnerabilities Bump minimatch from 10.2.1 to 10.2.4 in overrides to fix 10 high-severity ReDoS vulnerabilities (GHSA-7r86-cg39-jmmj, GHSA-23c5-xmqv-rm74). Also add .venv/ to ESLint ignores to prevent linting Python venv files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
137 lines
4.6 KiB
JavaScript
137 lines
4.6 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
/**
|
|
* Path resolution tests for shared home-path expansion logic.
|
|
*
|
|
* Run: node skills/clawsec-suite/test/path_resolution.test.mjs
|
|
*/
|
|
|
|
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { pass, fail, report, exitWithResults, withEnv } from "./lib/test_harness.mjs";
|
|
|
|
const __dirname = path.dirname(fileURLToPath(import.meta.url));
|
|
const LIB_PATH = path.resolve(__dirname, "..", "hooks", "clawsec-advisory-guardian", "lib");
|
|
const { resolveUserPath, resolveConfiguredPath } = await import(`${LIB_PATH}/utils.mjs`);
|
|
|
|
async function testTildeExpansion() {
|
|
const testName = "resolveUserPath: expands leading tilde";
|
|
await withEnv("HOME", "/tmp/clawsec-home", async () => {
|
|
const resolved = resolveUserPath("~/skills/clawsec-suite", { label: "test tilde" });
|
|
const expected = path.normalize("/tmp/clawsec-home/skills/clawsec-suite");
|
|
if (resolved === expected) {
|
|
pass(testName);
|
|
} else {
|
|
fail(testName, `Expected ${expected}, got ${resolved}`);
|
|
}
|
|
});
|
|
}
|
|
|
|
async function testHomeVariableExpansion() {
|
|
const testName = "resolveUserPath: expands $HOME and ${HOME}";
|
|
await withEnv("HOME", "/tmp/clawsec-home", async () => {
|
|
const resolved1 = resolveUserPath("$HOME/skills", { label: "test $HOME" });
|
|
const resolved2 = resolveUserPath("${HOME}/skills", { label: "test ${HOME}" });
|
|
const expected = path.normalize("/tmp/clawsec-home/skills");
|
|
if (resolved1 === expected && resolved2 === expected) {
|
|
pass(testName);
|
|
} else {
|
|
fail(testName, `Expected ${expected}, got ${resolved1} / ${resolved2}`);
|
|
}
|
|
});
|
|
}
|
|
|
|
async function testUserProfileExpansion() {
|
|
const testName = "resolveUserPath: expands USERPROFILE syntaxes";
|
|
await withEnv("HOME", undefined, async () => {
|
|
await withEnv("USERPROFILE", "C:\\Users\\clawsec", async () => {
|
|
const resolved1 = resolveUserPath("%USERPROFILE%\\skills", { label: "test %USERPROFILE%" });
|
|
const resolved2 = resolveUserPath("$env:USERPROFILE\\skills", { label: "test $env:USERPROFILE" });
|
|
const expected = path.normalize("C:\\Users\\clawsec\\skills");
|
|
if (resolved1 === expected && resolved2 === expected) {
|
|
pass(testName);
|
|
} else {
|
|
fail(testName, `Expected ${expected}, got ${resolved1} / ${resolved2}`);
|
|
}
|
|
});
|
|
});
|
|
}
|
|
|
|
async function testEscapedTokenFails() {
|
|
const testName = "resolveUserPath: rejects escaped or unresolved home tokens";
|
|
try {
|
|
resolveUserPath("\\$HOME/skills", { label: "test escaped token" });
|
|
fail(testName, "Expected error for escaped token");
|
|
} catch (error) {
|
|
if (String(error).includes("Unexpanded home token")) {
|
|
pass(testName);
|
|
} else {
|
|
fail(testName, `Unexpected error: ${error}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
async function testConfiguredPathFallbackOnInvalidExplicit() {
|
|
const testName = "resolveConfiguredPath: falls back when explicit env value is invalid";
|
|
try {
|
|
let fallbackReason = "";
|
|
const resolved = resolveConfiguredPath("\\$HOME/skills", "/tmp/clawsec-default", {
|
|
label: "CLAWSEC_LOCAL_FEED_SIG",
|
|
onInvalid: (error, rawValue) => {
|
|
fallbackReason = `${rawValue} :: ${String(error)}`;
|
|
},
|
|
});
|
|
const expected = path.normalize("/tmp/clawsec-default");
|
|
if (
|
|
resolved === expected &&
|
|
fallbackReason.includes("\\$HOME/skills") &&
|
|
fallbackReason.includes("Unexpanded home token")
|
|
) {
|
|
pass(testName);
|
|
} else {
|
|
fail(testName, `Expected fallback ${expected}, got ${resolved} (${fallbackReason})`);
|
|
}
|
|
} catch (error) {
|
|
fail(testName, error);
|
|
}
|
|
}
|
|
|
|
async function testConfiguredPathUsesValidExplicit() {
|
|
const testName = "resolveConfiguredPath: keeps valid explicit value";
|
|
try {
|
|
const resolved = resolveConfiguredPath("$HOME/skills", "/tmp/clawsec-default", {
|
|
label: "CLAWSEC_INSTALL_ROOT",
|
|
onInvalid: () => {
|
|
throw new Error("onInvalid should not run for a valid explicit path");
|
|
},
|
|
});
|
|
const expected = path.normalize(`${process.env.HOME || ""}/skills`);
|
|
if (resolved === expected) {
|
|
pass(testName);
|
|
} else {
|
|
fail(testName, `Expected ${expected}, got ${resolved}`);
|
|
}
|
|
} catch (error) {
|
|
fail(testName, error);
|
|
}
|
|
}
|
|
|
|
async function runTests() {
|
|
console.log("=== ClawSec Path Resolution Tests ===\n");
|
|
|
|
await testTildeExpansion();
|
|
await testHomeVariableExpansion();
|
|
await testUserProfileExpansion();
|
|
await testEscapedTokenFails();
|
|
await testConfiguredPathFallbackOnInvalidExplicit();
|
|
await testConfiguredPathUsesValidExplicit();
|
|
|
|
report();
|
|
exitWithResults();
|
|
}
|
|
|
|
runTests().catch((error) => {
|
|
console.error("Test runner failed:", error);
|
|
process.exit(1);
|
|
});
|