Close C5 TZ 4.1.1-R22 typo conflict (Flight-Map placeholder uses ДД.ММ.ГГГГ)
This commit is contained in:
@@ -162,7 +162,7 @@ Arbitrated case-by-case (Q2 = C). Each conflict blocks its owning plan's kickoff
|
||||
| C2 | 4.1.4-R23 / R24 / R25 | TZ Table 7 says Flight Map breadcrumb = `[Главная]` only on all map states | Prior React impl had `[Главная / Карта полетов]` (self-referential second crumb) | Prior React had two crumbs | TZ explicitly shows single crumb for all map pages | **Adopt TZ**: drop self-referential second crumb. Commit: `2fe5364`. |
|
||||
| C3 | 4.1.4-R12 / R13 | TZ Table 7 row 6 says departure/arrival leaf shows `{город вылета}-{город прилета}` (both cities) | Angular shows paired cities | `?request=` param encodes only one station (the searched one) | Showing paired cities at render time requires an extra API lookup for the other endpoint; not done in P1 | **Deferred arbitration**: leaf shows single searched station for now. Full city-pair deferred to P2 when flight-result data is in scope. Commit: `1821f7f`. Linked: 4.1.4-R12 / R13 marked Partial. |
|
||||
| C4 | 4.1.4-R14 | TZ Table 7 row 6 (transitions col) requires last breadcrumb crumb on details page to be clickable (navigates back to search with filter restored) | Angular: last crumb is a link | Previous React `Breadcrumbs` component rendered last crumb as non-link (`!isLast` guard) regardless of whether `url` was provided | TZ and Angular both require clickable leaf | **Adopt TZ**: removed `!isLast` guard — last crumb with `url` now rendered as `<a>` and clickable. Commit: `1821f7f`. Note: `aria-current="page"` is still set on the last crumb as required by R2. |
|
||||
| C5 | 4.1.1-R22 | TZ writes `"ДД.ММ.ГГГ"` (3 Г) for Flight Map date placeholder without geo consent | All other placeholders in TZ use `"ДД.ММ.ГГГГ"` (4 Г) | Not yet implemented (P6 scope) | Clear TZ typo — 3 Г is inconsistent with every other date placeholder in the document | **Treat as typo**: implement as `"ДД.ММ.ГГГГ"` (4 Г). Commit: pending (P6 start-page scope). Conflict to be closed when P6 implements Flight Map start-page. |
|
||||
| C5 | 4.1.1-R22 | TZ writes `"ДД.ММ.ГГГ"` (3 Г) for Flight Map date placeholder without geo consent | All other placeholders in TZ use `"ДД.ММ.ГГГГ"` (4 Г) | Verified: `src/i18n/locales/ru/common.json` line 323 → `"ДД.ММ.ГГГГ"` (4 Г) | Clear TZ typo — 3 Г is inconsistent with every other date placeholder in the document | **Verified in `FlightsMapFilter.tsx`** — placeholder uses 4-Г form (`"SHARED.DATE_FORMAT"` i18n key resolves to `"ДД.ММ.ГГГГ"`). No code change needed. C5 closed. Commit: `fcf4834`. |
|
||||
| C6 | Tab-tooltip cross-cutting (§4.1 opening text) | TZ tab tooltip for Board tab = `"в ближайшие дни"` | Angular reference (and pre-P2 React impl) had `"на ближайшие дни"` | React impl had `"на ближайшие дни"` (incorrect preposition) | TZ uses "в" (in the coming days); Angular reference used "на" (for the coming days) — a copy drift | **Adopt TZ**: changed to `"в ближайшие дни"`. Commit: `53b5359`. Schedule and Map tooltips already matched TZ; only Board tab was affected. |
|
||||
| C7 | 4.1.9.5-R3 (search history storage scope) | TZ §4.1.9.5 ¶1: history is session-scoped ("в рамках одной сессии") | No prior Angular reference compared | Prior React impl used `localStorage` (persisted across sessions) | TZ phrase "в рамках одной сессии" unambiguously requires session scope; `localStorage` was incorrect | **Resolved**: migrated `useSearchHistory` from `localStorage` to `sessionStorage`. Commit: `2b0a7ec`. Rule 4.1.9.5-R3 now Done. |
|
||||
| C8 | 4.1.14.1-R3 (Schedule week-tabs active range: `+210 days` → `+330 days`) | TZ §4.1.14.1 ¶3: active range = from week of `-1 day` up to week of `+330 days` | Angular reference not inspected for week count | Prior React impl used `WEEKS_AFTER=30` ≈ 210 days; TZ requires 330 days | TZ explicitly states `-1 day, +330 days` window; 30 weeks was an undocumented approximation | **Resolved**: replaced hardcoded `WEEKS_AFTER=30` with `scheduleWindowBounds()` that derives weeks from the canonical `[-1, +330]` bounds. Commit: `6f67c06`. Rule 4.1.14.1-R3 now Done. |
|
||||
@@ -200,7 +200,7 @@ Defines what the filter shows on the very first session visit: with geolocation
|
||||
| 4.1.1-R19 | Without geo consent, "Номер рейса" mode: `Номер рейса` placeholder, `Дата рейса` placeholder `"ДД.ММ.ГГГГ"` | 4.1.1 ¶7 | all | `OnlineBoardFilter.tsx` | Implemented | Pre-existing; flight-number mode without geo shows placeholders. | P2 |
|
||||
| 4.1.1-R20 | Without geo consent, Schedule start page per §4.1.7; all city/date placeholders; toggles unchecked | 4.1.1 ¶8 | all | `ScheduleStartPage.tsx` | Implemented | Pre-existing; c3c1f83 confirms no-geo path shows Schedule start page with all placeholders. | P2 |
|
||||
| 4.1.1-R21 | Without geo consent, Flight Map: `Город вылета` placeholder `"Откуда"`, `Город прилета` `"Куда"`, all toggles OFF; map shows full route network as dots | 4.1.1 ¶9 | all | `FlightsMapFilter.tsx`, `MapCanvas.tsx` | Done fbb84fc | No-geo path sets all toggles OFF per fbb84fc; dots rendering is P6 scope (noted separately). | P2 |
|
||||
| 4.1.1-R22 | Without geo consent, Flight Map `Дата рейса` placeholder `"ДД.ММ.ГГГ"` (sic — TZ typo, 3 Г; treat as `ДД.ММ.ГГГГ`) | 4.1.1 ¶9 | all | `FlightsMapFilter.tsx` | Conflict | TZ has obvious typo. Flag; treat as `ДД.ММ.ГГГГ`. Implementation deferred to P6. | P6 |
|
||||
| 4.1.1-R22 | Without geo consent, Flight Map `Дата рейса` placeholder `"ДД.ММ.ГГГ"` (sic — TZ typo, 3 Г; treat as `ДД.ММ.ГГГГ`) | 4.1.1 ¶9 | all | `FlightsMapFilter.tsx` | Done fcf4834 | Verified: placeholder uses 4-Г form via i18n key `"SHARED.DATE_FORMAT"` = `"ДД.ММ.ГГГГ"`. C5 closed. | P6 |
|
||||
| 4.1.1-R23 | Search results from Online-Board/Schedule persist in-session when user re-selects filter values (do NOT reset) | 4.1.1 ¶10 | all | state: `src/shared/state/` | Implemented | Cross-section store (P1) provides per-section state that persists across filter changes; verified by P1 e2e. | P2 |
|
||||
| 4.1.1-R24 | Flight Map results update immediately when filter changes (different behavior from Board/Schedule) | 4.1.1 ¶10 | all | `flights-map/hooks/*` | Done bc0b10b | Immediate-update behavior preserved by `useGeoCityDefault` migration; bc0b10b does not alter trigger logic. | P6 |
|
||||
| 4.1.1-R25 | Clearing `Дата рейса` on Flight Map → map shows range `-1 day, +6 months` | 4.1.1 ¶11 | all | `flights-map/*` | TBD | Not verified in P2. Verify at P6 kickoff. | P6 |
|
||||
|
||||
Reference in New Issue
Block a user