Commit Graph

509 Commits

Author SHA1 Message Date
gnezim 298f007463 Drop 11 non-null assertions in api.ts, DayGroupedFlightList, FlightCard
Regex capture groups and array boundary accesses replaced with nullish
fallbacks / explicit guards. Warning count: 41 → 30.
2026-04-20 09:19:14 +03:00
gnezim 1fc96b603e Drop 14 non-null assertions in ScheduleFlightBody + CityPickerPopup
- ScheduleFlightBody.tsx: hms regex capture uses `?? "0"` fallback;
  inline IIFEs expose last-leg and transfer-to-next in narrowed scope.
- CityPickerPopup.tsx: row.city1/city2/city1Airports are lifted into
  locals so the narrowing survives into JSX event handler closures.

Warning count: 55 → 41.
2026-04-20 08:33:33 +03:00
gnezim 6b6724f3de Drop 10 non-null assertions from MapCanvas zoom-layer loops
Replace `zoomLayers[c]![t]!` patterns with explicit null-guard
`continue` branches. The dimensions (2×5) are still initialized the
same way; the narrowing just makes the linter happy without changing
runtime behavior. Warning count: 65 → 55.
2026-04-20 08:28:57 +03:00
gnezim 5c47498472 Allow non-null assertions in tests; refactor two production hotspots to drop them
- eslint.config.js: disable no-non-null-assertion for *.test.ts/tsx and
  tests/** (fixture-driven tests routinely use arr[0]! after a length
  check — signal there is low).
- closestFlight.ts: replace flights.legs[0]! / flights[flights.length-1]!
  with explicit null checks.
- FlightDetailsAccordion.tsx: refactor transition + meal/service
  branches to use local consts narrowed by a preceding truthy check,
  dropping the `leg.transition!.registration!` patterns.

Warning count: 190 → 65. Remaining warnings are pre-existing production-code
non-null assertions spread across the codebase.
2026-04-20 08:24:01 +03:00
gnezim a982d9a669 Fix lint: route sessionStorage through shared storage module, drop dead imports
- storage.ts: add sessionStore wrapper (getRaw/setRaw/delete/clear) so
  transientPrefill + ScheduleStartPage tests don't trip the
  no-restricted-globals rule.
- transientPrefill.ts + ScheduleStartPage.test.tsx: use sessionStore.
- closestFlight.ts: hoist bracket-index key so no newline-before-[ ASI.
- Test files: hoist typeof import(...) into named type alias with
  type-only namespace import.
- Drop unused imports: FlightCard (Link, languageToLocale),
  OnlineBoardDetailsPage (operatingCarrier),
  ScheduleSearchPage (FlightList, inline import() types),
  PageLayout (FeedbackButton).
- Drop react-hooks/exhaustive-deps disable comments for a rule not
  registered in eslint.config.js.
2026-04-20 08:15:21 +03:00
gnezim 8e476b5883 OnlineBoardStartPage: background-position: left center (matches Angular) 2026-04-20 07:29:51 +03:00
gnezim 68e7b3e9ec Normalize 4/6/8px radii to vars.$border-radius (3px) across 5 SCSS files 2026-04-20 07:10:12 +03:00
gnezim 69020946b8 Card border-radius 8px→$border-radius (3px) on FlightsMiniList + FullRouteTimeline 2026-04-20 07:07:43 +03:00
gnezim 6faa01a998 DayTabs: 3px top-corner radius matching Angular date-tabs carousel arrows 2026-04-20 07:02:38 +03:00
gnezim 3577745477 Style Breadcrumbs as Angular's translucent pill (dark-blue-opacity bg, 3/10 padding) 2026-04-20 06:40:33 +03:00
gnezim da3f2713ac CityPickerPopup: gps-button uses $blue-light / $white / $blue-light--hover tokens 2026-04-20 06:38:14 +03:00
gnezim b6ed257a6a ErrorPage: use design tokens for code/input/focus colors 2026-04-20 06:35:33 +03:00
gnezim ef845f587f Final token sweep: pastel blues, blues, greys to design tokens (8 files) 2026-04-20 06:14:55 +03:00
gnezim b10e78f6a6 Token cleanup for OnlineBoardFilter + FlightsMap switch/tooltip colors 2026-04-20 06:11:26 +03:00
gnezim b8ab5af8aa Token cleanup for TimeGroup + FlightCard (#333/#f37b09/#fff/#e68200/#5b6b80 → tokens) 2026-04-20 06:08:43 +03:00
gnezim 2fdd7ac0ff Use tokens for FlightDetailsAccordion status colors (#c8102e/#f37b09/#4a90e2/#333/#657282) 2026-04-20 05:47:25 +03:00
gnezim 4d741c18e1 Token cleanup in OnlineBoardDetailsPage (#333/#657282/#d1dcea/#d0d5dd/#eee → tokens) 2026-04-20 05:44:41 +03:00
gnezim 8b0f4f75c2 Use tokens for FlightSchedule colors and FlightsMiniList flight-number navy 2026-04-20 05:41:35 +03:00
gnezim c1534bba44 Token cleanup for online-board components (#fff/#333/#657282/#d0dae5 → tokens) 2026-04-20 05:20:46 +03:00
gnezim 94e7180a2f Use colors.$white token across schedule components (6 files) 2026-04-20 05:16:56 +03:00
gnezim 928d072577 Align DetailsBackButton to Angular: left-aligned label, $button-height, tokens 2026-04-20 05:14:11 +03:00
gnezim d960e469ed Use colors.$white token for ScheduleFlightBody backgrounds/button text 2026-04-20 04:53:23 +03:00
gnezim 8e37fac674 Use design tokens for share-panel background/border/padding and 10px element gap 2026-04-20 04:49:13 +03:00
gnezim 89dd51cbaf Match Angular flight-events chip shape (squared 3px corners, 0/10 padding, line-height 16) 2026-04-20 04:47:01 +03:00
gnezim c8257baf26 Replace border-radius: 4px with vars.$border-radius (3px) to match Angular 2026-04-20 04:26:19 +03:00
gnezim 627f155f87 Replace #022040/#1a3a5c navy hex with colors.$blue-dark token 2026-04-20 04:21:47 +03:00
gnezim 2d7646d793 Replace custom brand hex with design tokens ($blue, $orange, $green, $red) across 13 SCSS files 2026-04-20 04:19:43 +03:00
gnezim fb82fc6ad1 Replace pastel-blue dividers/bg with $border and $blue-extra-light tokens (6 files) 2026-04-20 03:58:13 +03:00
gnezim 3bae0ee98f Replace hardcoded #e0e0e0 borders with $border-input and normalize $border-radius to 3px 2026-04-20 03:54:06 +03:00
gnezim 4aadab25e9 Normalize body-text #222 to colors.$text-color across 10 SCSS files 2026-04-20 03:50:54 +03:00
gnezim 1cd39b094e Match Angular per-carrier OperatorLogo aspect ratios (120x31 SU, etc) 2026-04-20 03:30:15 +03:00
gnezim db697d4b5e Switch TransferBar + FullRouteTimeline to design tokens; correct transfer icon size (20.5×6.5) 2026-04-20 03:26:10 +03:00
gnezim 0782674140 Match Angular BoardDetailsHeader typography (18px/500), use $border and $blue-light tokens 2026-04-20 03:23:08 +03:00
gnezim 1156dd6f90 Replace hardcoded #6b7280/#1c2330/#8a8a8a greys with design tokens ($light-gray/$text-color) 2026-04-20 03:02:10 +03:00
gnezim c4ba540e1c Normalize caption/time-note greys to $light-gray (#657282) across FlightCard, CityAutocomplete, details accordion, board header, and filter 2026-04-20 02:57:41 +03:00
gnezim 1842415eed Use $light-gray (#657282) for mini-list date/airport to match Angular tokens 2026-04-20 02:54:31 +03:00
gnezim aa2602475d Lay out AircraftPanel as 5-col grid (desktop) / 4 (tablet) / 2 (mobile) like Angular flight-props 2026-04-20 02:51:34 +03:00
gnezim 7cf15f11ab Match Angular typography: terminal-link color, board header padding/grid 2026-04-20 02:31:27 +03:00
gnezim 74d7c119d5 Match Angular FlightCard grid tracks, tablet overrides, and search-frame radius 2026-04-20 02:28:09 +03:00
gnezim 353bd62296 Render branded 404 page on invalid URLs and malformed params
Replace the inline 'Invalid parameters' fallbacks and the framework's
default '404' text with the existing Aeroflot 404 screen. Unknown
locale, malformed flight/route/station params, and unmatched URLs
(including bad paths like onlineboard//route/...) now all land on the
same ErrorPage component.
2026-04-20 02:23:16 +03:00
gnezim 0e9191be05 Match Angular PageLayout: 24px tablet padding, single title wrapper 2026-04-20 02:07:51 +03:00
gnezim bc15c83d22 Add 'Дата рейса' caption to DayTabs mobile dropdown on details page 2026-04-20 01:54:22 +03:00
gnezim 5a17962527 Stack board-details-header rows vertically on mobile 2026-04-20 01:50:55 +03:00
gnezim 4b6632cad5 Match Angular flights-map canvas height (500 → 800px) 2026-04-20 01:50:07 +03:00
gnezim 4095344b7b Revert "Convert schedule WeekTabs to day-of-week strip"
This reverts commit c097ab21fe.
2026-04-20 01:38:12 +03:00
gnezim c097ab21fe Convert schedule WeekTabs to day-of-week strip
Angular's schedule renders 7 day pills ("20 пн … 26 вс") spanning the
active week, not weekly date ranges. Match that: tabs now render the
seven days of selectedMonday's week with day-num + weekday-abbr stack.
Prev/next arrows shift by full weeks. Day clicks scroll to the
matching day group in DayGroupedFlightList for the schedule UX.
2026-04-20 01:29:53 +03:00
gnezim f1f0030b69 Auto-expand today's day group + dynamic dates in visual diff
Schedule list day accordion stays collapsed by default but auto-
opens the day matching today's date when it's in the visible week
window — mirrors Angular's p-accordion default-active behaviour
where today's flights are visible without a click. The user can
still collapse it; we never re-open after that for the same date.

Visual-diff URLs were hardcoded to a past date with the wrong React
URL format (Angular path-style /AAQ/16042026 instead of React's
single-segment /AAQ-20260420-00002400). Switch to dynamic
yyyyMMdd of today for onlineboard pages and Mon→Sun of the current
week for schedule. Schedule-route diff dropped from ~91% to ~28%
on desktop after these two fixes.
2026-04-20 01:17:58 +03:00
gnezim 6a3edeb0e7 Make visual-parity diff script env-configurable
ANGULAR_BASE / ANGULAR_PATH_PREFIX / REACT_BASE / MOCK_ANGULAR /
MOCK_REACT env vars let the script target the live test env
(https://flights.test.aeroflot.ru/ru-ru) without code changes.

Used to rerun the Visual Parity Report against the live Angular
backend instead of a local ng serve.
2026-04-20 00:58:15 +03:00
gnezim 9cdc8fd75b Default schedule day groups to collapsed
Match Angular's p-accordion default-collapsed state on the schedule
results page. State now tracks expanded days (default empty)
instead of collapsed days (default empty), so the initial render
shows day headers only and the user clicks to reveal flights.
2026-04-20 00:35:44 +03:00
gnezim e05ef1ca20 Render rich Schedule details page + fix broken SEO key
Schedule details page used to show only a one-line FlightCard and
stop. Reuse ScheduleFlightBody so each flight in the chain renders
the same per-leg layout the schedule results page uses (route
summary, leg cards, transit pill, share/Купить/Детали рейса
actions). Add a `Вернуться к Расписанию` back link to the header.

While here, fix the SEO title key — buildScheduleDetailsSeo was
calling SEO.SCHEDULE.DETAILS.TITLE with `flights={...}`, but the
i18n bundle only defines SEO.SCHEDULE.FLIGHT-DETAILS.TITLE with
`flightNumber={...}`. The unresolved key was leaking into the
document title as "SEO.SCHEDULE.DETAILS.TITLE".
2026-04-20 00:30:39 +03:00