61 lines
3.0 KiB
Markdown
61 lines
3.0 KiB
Markdown
---
|
|
name: review-only
|
|
description: Read-only review workflow for current diff or requested areas.
|
|
---
|
|
|
|
## explore
|
|
role: explorer
|
|
output: review-context.md
|
|
|
|
Identify changed or relevant areas for review: {goal}
|
|
|
|
Use `git status --short`, `git diff`, and targeted code search. Do not edit files. Keep this exploration short: produce `review-context.md` after a compact status/diff overview and a bounded inspection of the scoped files. Do not run incremental `sed`, `head`, `tail`, or `git diff | grep` widening loops; if output is too broad, narrow by file or exact line range.
|
|
|
|
Tool policy: do not call `glob` or any unavailable abstract discovery tool. Use bash discovery only: `rg --files`, `rg -n`, `find`, `sed`, `nl`, and `git grep`. If a tool returns `Tool <name> not found`, stop using it immediately; if the same tool error repeats twice, stop the task and report the blocker. Do not repeat failed tool calls or shell commands. If a command exits non-zero with no useful output, do not retry it unchanged; inspect source/tests or change the hypothesis first. If a focused test fails, use the failure location to inspect and fix code/tests; do not repeatedly grep test output for unrelated terms. After two failed verification attempts without a code or test change, stop and report the blocker. Do not continue after five consecutive calls that add no new information. Treat semantically equivalent commands as repeats even when numeric limits or filters change; do not widen `sed`, `head`, `tail`, or `git diff | grep` ranges step by step.
|
|
|
|
## code-review
|
|
role: reviewer
|
|
dependsOn: explore
|
|
parallelGroup: review
|
|
reads: review-context.md
|
|
|
|
Review correctness, maintainability, regressions, tests, project-rule compliance, SSR safety, and Module Federation constraints. Start with the reviewer heartbeat command from the reviewer agent instructions, then inspect changed files in bounded diff chunks. Do not use direct `read`; use `bash` only. If the review cannot finish, return a partial review with residual risk instead of waiting silently.
|
|
|
|
## critical-review
|
|
role: critic
|
|
dependsOn: explore
|
|
parallelGroup: review
|
|
reads: review-context.md
|
|
|
|
Challenge assumptions, missing verification, overengineering, parity gaps, and risky deployment implications.
|
|
|
|
## unit-check
|
|
role: unit
|
|
dependsOn: code-review, critical-review
|
|
parallelGroup: verify
|
|
verify: true
|
|
|
|
Identify the minimum fast verification commands needed and run them when appropriate.
|
|
|
|
## e2e-check
|
|
role: e2e
|
|
dependsOn: code-review, critical-review
|
|
parallelGroup: verify
|
|
verify: true
|
|
|
|
Identify browser or visual checks needed and run them when appropriate. Use Playwright MCP when interactive evidence helps.
|
|
|
|
## summarize
|
|
role: docs
|
|
dependsOn: unit-check, e2e-check
|
|
output: review-summary.md
|
|
|
|
Summarize findings first, ordered by severity with file:line evidence. Include open questions and residual test gaps.
|
|
|
|
## gitops
|
|
role: gitops
|
|
dependsOn: summarize
|
|
verify: true
|
|
|
|
Inspect git state. For review-only tasks, do not commit unless the workflow produced intentional file changes and verification passed.
|